From 632be3bd7073941e5df10a9bc45343c154a4ef95 Mon Sep 17 00:00:00 2001
From: Grey Li <withlihui@gmail.com>
Date: Wed, 26 Apr 2017 18:50:22 +0800
Subject: [PATCH 1/4] Add support for URL section in pagination button

When use this macro to paginate comments on a post page, you have to scroll to comment area every time after you click the page button. It is useful to add a URL section in page button, here is a simple use case: `render_pagination(pagination, section='#comment')`.
---
 flask_bootstrap/templates/bootstrap/pagination.html | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/flask_bootstrap/templates/bootstrap/pagination.html b/flask_bootstrap/templates/bootstrap/pagination.html
index 63c22b30..2ab6c7ad 100644
--- a/flask_bootstrap/templates/bootstrap/pagination.html
+++ b/flask_bootstrap/templates/bootstrap/pagination.html
@@ -14,7 +14,8 @@
                            next=('&raquo;')|safe,
                            size=None,
                            ellipses='…',
-                           args={}
+                           args={},
+                           section=None
                            )
 -%}
 {% with url_args = {} %}
@@ -26,13 +27,13 @@
   <ul class="pagination{% if size %} pagination-{{size}}{% endif %}"{{kwargs|xmlattr}}>
   {# prev and next are only show if a symbol has been passed. #}
   {% if prev != None -%}
-    <li{% if not pagination.has_prev %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.prev_num) if pagination.has_prev else '#'}}">{{prev}}</a></li>
+    <li{% if not pagination.has_prev %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.prev_num) if pagination.has_prev else '#'}}{% if section %}{{section}}{% endif %}">{{prev}}</a></li>
   {%- endif -%}
 
   {%- for page in pagination.iter_pages() %}
     {% if page %}
       {% if page != pagination.page %}
-        <li><a href="{{_arg_url_for(endpoint, url_args, page=page)}}">{{page}}</a></li>
+        <li><a href="{{_arg_url_for(endpoint, url_args, page=page)}}{% if section %}{{section}}{% endif %}">{{page}}</a></li>
       {% else %}
         <li class="active"><a href="#">{{page}} <span class="sr-only">(current)</span></a></li>
       {% endif %}
@@ -42,7 +43,7 @@
   {%- endfor %}
 
   {% if next != None -%}
-    <li{% if not pagination.has_next %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.next_num) if pagination.has_next else '#'}}">{{next}}</a></li>
+    <li{% if not pagination.has_next %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.next_num) if pagination.has_next else '#'}}{% if section %}{{section}}{% endif %}">{{next}}</a></li>
   {%- endif -%}
   </ul>
 </nav>

From 8bb2a56703f94491edf9b9e3f2a16ffb086f79e5 Mon Sep 17 00:00:00 2001
From: Grey Li <withlihui@gmail.com>
Date: Wed, 26 Apr 2017 19:00:15 +0800
Subject: [PATCH 2/4] Update SQLAlchemy docs for pagination URL section

---
 docs/sqlalchemy.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/docs/sqlalchemy.rst b/docs/sqlalchemy.rst
index 709770b7..6a8a9be6 100644
--- a/docs/sqlalchemy.rst
+++ b/docs/sqlalchemy.rst
@@ -21,6 +21,7 @@ automatically rendered through the ``render_pagination`` macro:
                      ellipses='…',\
                      size=None,\
                      args={},\
+                     section=None,\
                      **kwargs)
 
    Renders a pager for query pagination.
@@ -39,5 +40,6 @@ automatically rendered through the ``render_pagination`` macro:
    :param size: Can be 'sm' or 'lg' for smaller/larger pagination.
    :param args: Additional arguments passed to :func:`~flask.url_for`. If
                 ``endpoint`` is ``None``, uses :attr:`~flask.Request.args` and
-                :attr:`~flask.Request.view_args`
+                :attr:`~flask.Request.view_args`.
+   :param section: Add url section to link, such as ``#comment``. 
    :param kwargs: Extra attributes for the ``<ul>``-element.

From 969d141ac4e98720ebca689caf0d602a59323ed9 Mon Sep 17 00:00:00 2001
From: Grey Li <withlihui@gmail.com>
Date: Wed, 26 Apr 2017 20:46:36 +0800
Subject: [PATCH 3/4] Simplify logic and correct word

---
 flask_bootstrap/templates/bootstrap/pagination.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/flask_bootstrap/templates/bootstrap/pagination.html b/flask_bootstrap/templates/bootstrap/pagination.html
index 2ab6c7ad..e7a0192c 100644
--- a/flask_bootstrap/templates/bootstrap/pagination.html
+++ b/flask_bootstrap/templates/bootstrap/pagination.html
@@ -15,7 +15,7 @@
                            size=None,
                            ellipses='…',
                            args={},
-                           section=None
+                           fragment=''
                            )
 -%}
 {% with url_args = {} %}
@@ -27,13 +27,13 @@
   <ul class="pagination{% if size %} pagination-{{size}}{% endif %}"{{kwargs|xmlattr}}>
   {# prev and next are only show if a symbol has been passed. #}
   {% if prev != None -%}
-    <li{% if not pagination.has_prev %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.prev_num) if pagination.has_prev else '#'}}{% if section %}{{section}}{% endif %}">{{prev}}</a></li>
+    <li{% if not pagination.has_prev %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.prev_num) if pagination.has_prev else '#'}}{{fragment}}">{{prev}}</a></li>
   {%- endif -%}
 
   {%- for page in pagination.iter_pages() %}
     {% if page %}
       {% if page != pagination.page %}
-        <li><a href="{{_arg_url_for(endpoint, url_args, page=page)}}{% if section %}{{section}}{% endif %}">{{page}}</a></li>
+        <li><a href="{{_arg_url_for(endpoint, url_args, page=page)}}{{fragment}}">{{page}}</a></li>
       {% else %}
         <li class="active"><a href="#">{{page}} <span class="sr-only">(current)</span></a></li>
       {% endif %}
@@ -43,7 +43,7 @@
   {%- endfor %}
 
   {% if next != None -%}
-    <li{% if not pagination.has_next %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.next_num) if pagination.has_next else '#'}}{% if section %}{{section}}{% endif %}">{{next}}</a></li>
+    <li{% if not pagination.has_next %} class="disabled"{% endif %}><a href="{{_arg_url_for(endpoint, url_args, page=pagination.next_num) if pagination.has_next else '#'}}{{fragment}}">{{next}}</a></li>
   {%- endif -%}
   </ul>
 </nav>

From e61fe56400aa826af300e68696a09025ff17ddd0 Mon Sep 17 00:00:00 2001
From: Grey Li <withlihui@gmail.com>
Date: Wed, 26 Apr 2017 20:48:11 +0800
Subject: [PATCH 4/4] Improve wording

---
 docs/sqlalchemy.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/sqlalchemy.rst b/docs/sqlalchemy.rst
index 6a8a9be6..ab872800 100644
--- a/docs/sqlalchemy.rst
+++ b/docs/sqlalchemy.rst
@@ -21,7 +21,7 @@ automatically rendered through the ``render_pagination`` macro:
                      ellipses='…',\
                      size=None,\
                      args={},\
-                     section=None,\
+                     fragment='',\
                      **kwargs)
 
    Renders a pager for query pagination.
@@ -41,5 +41,5 @@ automatically rendered through the ``render_pagination`` macro:
    :param args: Additional arguments passed to :func:`~flask.url_for`. If
                 ``endpoint`` is ``None``, uses :attr:`~flask.Request.args` and
                 :attr:`~flask.Request.view_args`.
-   :param section: Add url section to link, such as ``#comment``. 
+   :param fragment: Add url fragment into link, such as ``#comment``. 
    :param kwargs: Extra attributes for the ``<ul>``-element.