Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: --target-arch amd64 is completely wrong #4

Open
xtaran opened this issue Sep 23, 2020 · 0 comments
Open

Makefile: --target-arch amd64 is completely wrong #4

xtaran opened this issue Sep 23, 2020 · 0 comments

Comments

@xtaran
Copy link

xtaran commented Sep 23, 2020

Makefile contains this line:

dpkg-buildpackage -us -uc -b --target-arch amd64

This is wrong from multiple points of view:

  • There is nothing architecture-dependent (it's a shell script after all!), so the package should be archicture all.
  • The architecture is already specified via debian/control, not the commandline. Should be all, not any there, too.
  • You don't know on which architecture the user will later use this script. Won't be installable on a Raspberry Pi which either has architecture armhf or arm64. The Architecture: any in debian/control already chooses the proper target architecture (the one of the host) by default, if you don't want to do cross-compiling for another architecture.

So please:

  • Just drop the --target-arch amd64 from Makefile completely.
  • Change Architecture: any to Architecture: all in debian/control.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant