Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly awkward sentences on flex-basis page #37597

Open
Hexstream opened this issue Jan 10, 2025 · 1 comment · May be fixed by #37601
Open

Slightly awkward sentences on flex-basis page #37597

Hexstream opened this issue Jan 10, 2025 · 1 comment · May be fixed by #37601
Labels
Content:CSS Cascading Style Sheets docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@Hexstream
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis

What specific section or headline is this issue about?

Flex basis 0 vs 0%

What information was incorrect, unhelpful, or incomplete?

"these which" is awkward:

We include two same-structure flex containers. These which will be styled similarly, except for their flex-basis values.

I would just rephrase as:

We include two same-structure flex containers, which will be styled similarly except for their flex-basis values.


"to the column" is awkward:

We set the flex-direction to the column.

Either of these would work:

We set flex-direction to column.

We set the flex-direction to column.


"item" should be "items":

The first container's flex items have a flex-basis value of 0 and the second container's flex item have a flex-basis value of 0%.

Also, I think a slightly better phrasing would be:

The first container's flex items have a flex-basis value of 0, while the second container's flex items have a flex-basis value of 0%.


Lastly, this is not an error but I would use "cannot" instead of "can not".

What did you expect to see?

No awkward sentences and no typo.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@Hexstream Hexstream added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 10, 2025
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 10, 2025
SurajKharkwal added a commit to SurajKharkwal/content that referenced this issue Jan 11, 2025
@SurajKharkwal SurajKharkwal linked a pull request Jan 11, 2025 that will close this issue
@SurajKharkwal
Copy link

Hi, I’ve submitted a pull request that fixes the issue. You can view it here. The PR corrects the typo in the flex-basis documentation under the section "Flex basis: 0 vs 0%".

Looking forward to your feedback!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants