Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad layout in landscape #24

Open
Jean-BaptisteC opened this issue Apr 2, 2024 · 8 comments
Open

Bad layout in landscape #24

Jean-BaptisteC opened this issue Apr 2, 2024 · 8 comments
Labels
enhancement Improvement to existing feature help wanted Extra attention is needed

Comments

@Jean-BaptisteC
Copy link

Device Info

  • Brand: Google
  • Model name: Pixel 6
  • Android version: 14

Steps to Reproduce

  • start app
  • rotate device
@meenbeese meenbeese added the enhancement Improvement to existing feature label Apr 2, 2024
@meenbeese meenbeese added the help wanted Extra attention is needed label May 29, 2024
@Saipavan1239
Copy link

I think i can help you with tht but i need a bit of details of how u want it to be done (like how do u want me to make it).

@meenbeese
Copy link
Owner

Thank you for your interest @Saipavan1239.

A good starting point would be to center the image properly and show the You do not have any alarms... text properly, which is currently cut off entirely. Also, the clock on the top is huge in landscape, which should also be fixed. I think the UI when the have at least one alarm is manageable for now. A long term plan could be to move the tabs to the left side on landscape (not sure if it is even doable) or maybe find some other creative solution to replace the tabs?

@Saipavan1239
Copy link

Saipavan1239 commented Jun 8, 2024

image
how does this look or do u need any modifications.
If u want to do any changes i'll do it and will add the xml code
this image is just zoomed in but its actually a landscape of mobile version

@meenbeese
Copy link
Owner

Yes, this looks good to me. It is exactly how I imagined an optimal solution would look like. Maybe the alarm sizes can be adjusted so that they don't span the whole width, or more alarms can be displayed next to each other, but that can be discussed later on. For now, this is a great start.

@Saipavan1239
Copy link

so how can i send u the code for this design i just made this design as simpler as possible, maybe i can add the adjustments i want so how can we take this forward should i just complete the code and send u some link or do you have anyother idea.

@meenbeese
Copy link
Owner

Please raise a PR (using Git) against the main branch of this repo so that we can review and discuss your changes. Also, make sure to include screenshots of your changes.

@Saipavan1239
Copy link

I would certainly do that, but the problem is that I still need to make some changes to the code and it will keep me busy for a week or two, after which will I be able to raise the PR and get the code fully finished and submit it?

@meenbeese
Copy link
Owner

Yes, take your time to write well-polished code instead of rushing it and doing a half-baked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants