Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are failed #6

Open
meisyal opened this issue Nov 9, 2020 · 4 comments
Open

Unit tests are failed #6

meisyal opened this issue Nov 9, 2020 · 4 comments

Comments

@meisyal
Copy link
Owner

meisyal commented Nov 9, 2020

If you check commit d0c6ae4, we still have six failing unit tests. These unit tests use default dictionary (Kateglo). Let's break them down one-by-one:

  1. Unit test failed to stem "-lah, -kah, -tah, -pun" suffixes

    This happened because the stemmer failed to stem "apatah" word. "apatah" word exists in default dictionary. So, it's considered a root word or no need to be stemmed.

  2. Unit test failed to stem "-i, -kan, -an" suffixes

    This happened because the stemmer failed to stem "belikan" word. The cause is the same with previous point.

  3. Unit test failed to stem loop last return of enhanced confix stripping

    This happened because the stemmer failed to stem "menerangi", "berimanlah", and "memuaskan" words. Need further investigation to find the cause.

  4. Unit test failed to stem modified enhanced confix stripping with infix

    This happened because the stemmer failed to stem "rerata" and "lelembut" words. These words exist in dictionary.

  5. Unit test failed to remove prefix recursively

    This happened because the stemmer failed to stem "kesepersepuluhnya" word. Need further investigation to find the cause.

  6. Unit test failed to stem adopted foreign suffixes

    This happened because the stemmer failed to stem "idealis" and "idealisme" words. Both exist in dictionary.

@meisyal
Copy link
Owner Author

meisyal commented Nov 11, 2020

To fix unit test number 1, we will replace the word "apatah", like "manatah" and "siapatah". Both of these words don't exist in default dictionary. Then, we will move "apatah" to unit test with custom dictionary.

@meisyal
Copy link
Owner Author

meisyal commented Nov 12, 2020

For unit test number 2, we will do the same like previous comment. "belikan" will be replaced with other word that doesn't exist in default dictionary. "abaikan", "hijaukan", and "ramaikan" are the examples.

"belikan" has two meanings. The first meaning is to buy something and the second meaning is a field in the forest. This Ruby gem can't distinguish homograph. Gem limitation should be documented later.

@meisyal
Copy link
Owner Author

meisyal commented Nov 27, 2020

For unit test number 4 and 6, we will move the words, "rerata", "lelembut", "idealis", and "idealisme", to unit test with custom dictionary as well.

@meisyal meisyal mentioned this issue Dec 28, 2020
@meisyal
Copy link
Owner Author

meisyal commented Apr 11, 2021

Progress checklist:

  • Unit test failed to stem "-lah, -kah, -tah, -pun" suffixes
  • Unit test failed to stem "-i, -kan, -an" suffixes
  • Unit test failed to stem loop last return of enhanced confix stripping
  • Unit test failed to stem modified enhanced confix stripping with infix
  • Unit test failed to remove prefix recursively
  • Unit test failed to stem adopted foreign suffixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant