Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include expected environment variables in --about #213

Closed
MeltyBot opened this issue Sep 7, 2021 · 5 comments
Closed

Include expected environment variables in --about #213

MeltyBot opened this issue Sep 7, 2021 · 5 comments

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented Sep 7, 2021

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/214

Originally created by @edgarrmondragon on 2021-09-07 16:47:46


Summary

Include expected environment variables as part of the output of the --about CLI option.

Proposed benefits

Plugin developers developers and users can see the names of the environment variables their tap/target will look for when using --config=ENV.

This could later be used to by Meltano to set alternative names (aliases) for the plugin environment variables.

Proposal details

Include the environment variable names of settings in the JSON Schema printed out by --about. Something like

{
  "name": "my-tap",
  "version": "0.0.1",
  "sdk_version": "0.3.6",
  "capabilities": [
    "sync",
    "catalog",
    "state",
    "discover"
  ],
  "settings": {
    "type": "object",
    "properties": {
      "password": {
        "type": [
          "string"
        ],
        "environmentVariables": [
          "MY_TAP_PASSWORD"
        ]
      },
      "base_url": {
        "type": [
          "string",
          "null"
        ],
        "default": "https://someapi.com",
        "environmentVariables": [
          "MY_TAP_BASE_URL"
        ]
      }
    }
    "required": [
      "password"
    ]
  }
}

Best reasons not to build

Such a field is not part of the JSON Schema spec.

@MeltyBot
Copy link
Contributor Author

@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon edgarrmondragon added the good first issue Good for newcomers label Jul 20, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

Copy link

stale bot commented Jul 19, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 19, 2024
@edgarrmondragon
Copy link
Collaborator

Closed by #2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants