Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Timeout for killing children in the subprocess supervisor #917

Open
mat-hek opened this issue Dec 6, 2024 · 0 comments
Open

[Core] Timeout for killing children in the subprocess supervisor #917

mat-hek opened this issue Dec 6, 2024 · 0 comments

Comments

@mat-hek
Copy link
Member

mat-hek commented Dec 6, 2024

Currently the SubprocessSupervisor, which is responsible for terminating children and utility processes, waits until they all exit. Sometimes they trap exit though and never exit due to a bug, and everything hangs, which is hard to debug. I think there should be a 5-second timeout after which the supervisor force kills the given process. We can make this timeout configurable, but I'm not sure it's needed. The same should probably be done in the PipelineSupervisor

@mat-hek mat-hek added this to Smackore Dec 6, 2024
@mat-hek mat-hek moved this to Backlog in Smackore Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant