From c03c41c2a1794a0011cfba17d72259c9281070af Mon Sep 17 00:00:00 2001 From: Drew Knab Date: Thu, 6 Jun 2024 10:24:09 -0400 Subject: [PATCH 1/2] small changes to the code samples --- basic_pipeline_extension/02_Bin.md | 2 +- basic_pipeline_extension/03_DynamicPads.md | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/basic_pipeline_extension/02_Bin.md b/basic_pipeline_extension/02_Bin.md index e6c937f..f7790ee 100644 --- a/basic_pipeline_extension/02_Bin.md +++ b/basic_pipeline_extension/02_Bin.md @@ -34,7 +34,7 @@ defmodule Basic.Bin do spec = [ child(:input, %Basic.Elements.Source{location: options.input_filename}) |> child(:ordering_buffer, Basic.Elements.OrderingBuffer) - |> to(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4}) + |> child(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4}) |> bin_output(:output) ] diff --git a/basic_pipeline_extension/03_DynamicPads.md b/basic_pipeline_extension/03_DynamicPads.md index 19ad5c6..f7300ee 100644 --- a/basic_pipeline_extension/03_DynamicPads.md +++ b/basic_pipeline_extension/03_DynamicPads.md @@ -41,8 +41,6 @@ The very first thing we need to do is to use the `def_input_pads` appropriately. ```elixir ... def_input_pad :input, - demand_unit: :buffers, - flow_control: :pull, availability: :on_request, accepted_format: %Basic.Formats.Frame{encoding: :utf8} ... From b6327799be08c6764f084ae5504a0e3391bffa19 Mon Sep 17 00:00:00 2001 From: Drew Knab Date: Mon, 24 Jun 2024 10:29:14 -0400 Subject: [PATCH 2/2] Correction based on review comments --- basic_pipeline_extension/03_DynamicPads.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/basic_pipeline_extension/03_DynamicPads.md b/basic_pipeline_extension/03_DynamicPads.md index f7300ee..9f0921a 100644 --- a/basic_pipeline_extension/03_DynamicPads.md +++ b/basic_pipeline_extension/03_DynamicPads.md @@ -41,6 +41,8 @@ The very first thing we need to do is to use the `def_input_pads` appropriately. ```elixir ... def_input_pad :input, + demand_unit: :buffers, + flow_control: :manual, availability: :on_request, accepted_format: %Basic.Formats.Frame{encoding: :utf8} ...