Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side validation missing. #1

Open
brett-lempereur opened this issue Feb 19, 2015 · 0 comments
Open

Server side validation missing. #1

brett-lempereur opened this issue Feb 19, 2015 · 0 comments

Comments

@brett-lempereur
Copy link

There needs to be some validation on the server side beyond "it's a valid JSON document so let's store it." At a minimum we should:

  • Check that the size of the response is reasonable (<1MB?) before attempting to interpret it.
  • Check that none of the identification fields are empty.
  • Check that the email address is valid.
  • Check that at least one asset has been submitted.
  • Check that all assets are not missing required fields.

We should be safe in terms of JSON parsing as the default Python configuration will stick to its conversion table and not perform magic with deserialising objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant