Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] tagged docker image v1.6.x #26

Open
the-hotmann opened this issue Sep 29, 2023 · 7 comments
Open

[Request] tagged docker image v1.6.x #26

the-hotmann opened this issue Sep 29, 2023 · 7 comments

Comments

@the-hotmann
Copy link

Hi Matthew,

thank you very much for building docker images for InvoicePlane.
I just checked out your DockerHub repo for InvoicePlane and noticed, that you do not push tagged versions of InvoicePlane v1.6.
Is there any chance you can add these versions aswell?
I guess for people that want to stay at 1.6 this would be very valuable.

Also I would be keen to know if you could build the Image for some more archs.
You can try to replace your platform parameter with this:

Alpine 3.15:

linux/amd64,linux/amd64/v2,linux/amd64/v3,linux/386,linux/arm64,linux/arm/v8,linux/arm/v7,linux/arm/v6,linux/ppc64le,linux/s390x

Alpine 3.19:

linux/amd64,linux/amd64/v2,linux/amd64/v3,linux/386,linux/arm64,linux/arm/v8,linux/arm/v7,linux/arm/v6,linux/ppc64le,linux/s390x,linux/riscv64

Note, that alpine 3.19 is not released yet, and you might not be able to have all dependencies shipped there by default. But it will add the arch riscv64.

Thanks in advance!

@mhzawadi
Copy link
Owner

Hi @the-hotmann

Thanks for your request, I had missed that version 1.6 was stable. Will see about getting a tagged version out soon

As for the architectures, will see what Github will let me build

@mhzawadi
Copy link
Owner

Hey, a tagged 1.6 is now out. a quick test on my mac shows it works fine.

As for the architectures, do you have an architecture you need?

@the-hotmann
Copy link
Author

Hey, a tagged 1.6 is now out. a quick test on my mac shows it works fine.

Thanks! Nice to hear you already tested. Will try to upgrade mine to 1.6.0 and see.

do you have an architecture you need?

Yes, linux/amd64/v2 and linux/amd64/v3. These two architectures are necessary because modern CPUs typically utilize more advanced instructions than the standard linux/amd64 (basically linux/amd64/v1).
Apart from these, I generally aim to build for as many architectures as possible, as a wider range of options can benefit more users. If any platform encounters issues during the build process, I will exclude it, as I want to avoid investing excessive time in troubleshooting. However, I will include all architectures that work successfully.

@mhzawadi
Copy link
Owner

bad news, the Github action I use doesn't have linux/amd64/v2 or linux/amd64/v3 in it.

@the-hotmann
Copy link
Author

bad news, the Github action I use doesn't have linux/amd64/v2 or linux/amd64/v3 in it.

Thanks for heading back. I usually build my docker containers on my own servers, where you can choose the arch you want with BUILDKIT and multi-platform Images to build for other platforms, or even QEMU.

But if that is too much don't worry, I will try to do this, once I have time to look into this :)

@mhzawadi
Copy link
Owner

Hey @the-hotmann

Will see how many architectures build on my dev branch, once I have the list will merge to main

@mhzawadi
Copy link
Owner

mhzawadi commented Jul 1, 2024

Hello 👋🏼

Is this now sorted with the merge of the Make the whole config dockerized PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants