Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context propagation in mp-fault-tolerance #108

Open
pavolloffay opened this issue Oct 12, 2018 · 3 comments
Open

Context propagation in mp-fault-tolerance #108

pavolloffay opened this issue Oct 12, 2018 · 3 comments

Comments

@pavolloffay
Copy link
Contributor

Some methods in fault-tolerance are executed on a different thread which breaks context. Namely, methods annotated with @Asynchronous 1 , but also @Timeout 2 (might not apply for all impls 3).
@pavolloffay pavolloffay mentioned this issue Oct 12, 2018
Open
@pavolloffay
Copy link
Contributor Author

https://github.com/michalszynkiewicz/thorntail-quotes/blob/master/src/main/java/io/thorntail/example/quotes/ads/AdRetriever.java#L39

@pavolloffay pavolloffay mentioned this issue Oct 23, 2018
Closed
@Ladicek
Copy link

Ladicek commented Feb 20, 2020

I wonder which specification should "own" this, and I'd probably lean towards MP Fault Tolerance. On the other hand, if MP Context Propagation is ever added to MP Platform, then it's probably MP OpenTracing who "owns" tracing context propagation...

@Ladicek
Copy link

Ladicek commented Feb 20, 2020

Also, it's really only @Asynchronous who mandates execution on different thread. The fact that @Timeout methods were also called on different threads with SmallRye Fault Tolerance 2.x was a bug and was fixed in SmallRye Fault Tolerance 4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ladicek @pavolloffay