Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pattern for multiple applications #119

Open
fmhwong opened this issue Oct 31, 2018 · 3 comments
Open

Skip pattern for multiple applications #119

fmhwong opened this issue Oct 31, 2018 · 3 comments
Assignees

Comments

@fmhwong
Copy link
Contributor

fmhwong commented Oct 31, 2018

In the spec we mentioned

Server side tracing can be disabled by specifying a skip pattern which is used to match with HTTP path UriInfo.getPath(). If the regex matches with HTTP path then tracing for the given server request is disabled even if the method or class is annotated with @Traced. The configuration does not disable any outbound request made from the disabled server endpoint.

UriInfo.getPath() does not include the context root of the app. What if we have 2 apps that have the same paths but just want to skip one but not the other.

@pavolloffay pavolloffay self-assigned this Oct 31, 2018
@pavolloffay
Copy link
Contributor

I can think of two possible solutions:

  1. require context path + path in the skip pattern
  2. properties files are scoped per app so the problem is only when using "global" sources like environmental or system properties which are reflected to all deployments. So the second approach is to clarify that when using global configs the URL is applied to all deployments.

@pavolloffay
Copy link
Contributor

The other issue with the current spec is that UriInfo.getPath() does not include application path so even two distinct apps would disable tracing for the same endpoint.

I think the way to go is 1. - specify the full URL (without host port schema..) in the skip pattern.

@pavolloffay
Copy link
Contributor

More generic discussion moved to https://groups.google.com/forum/#!topic/microprofile/5sT6tgzvBic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants