Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets keep showing 'Loading content...' instead of 'No pull requests available` #291

Open
JvandeKraats opened this issue Nov 22, 2024 · 1 comment
Labels
Issue-Bug Something isn't working or needs investigation Needs-Triage New issue that the core contributors need to triage

Comments

@JvandeKraats
Copy link

Dev Home version

0.1901.687.0

Dev Home Azure Extension version

0.1300.624.0

Windows build number

10.0.26120.0

Other software

No response

Steps to reproduce the bug

I've added three widgets, one 'My Pull Requests' and two 'Pull Requests'.
These widgets worked fine the first time that I added them.
However, over the next few days, I noticed that the widgets that would logically not show any data (there were no PR's for that specific repo for example) would just show loading content... all the time.
I would expect these widgets to read something like No data to be shown or No data available.
I do recall seeing a message similar to this once or twice on the widgets.

Here is a screenshot of what I mean (added white boxes over some parts to anonymize them)

Image

Expected result

When a widget on the dashboard would not contain any data (because the repository doesn't currently have any PRs open) I would expect that widget to show something to the extend of Currently no open Pull Requests available.

Actual result

The widgets keep showing Loading content...

Included System Information

No response

@JvandeKraats JvandeKraats added the Issue-Bug Something isn't working or needs investigation label Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Nov 22, 2024
@JvandeKraats
Copy link
Author

After a quick look at the code, I would say this line (in AzurePullRequestsRepositoryWidget) might be a bit incorrect:
itemsData.Add("is_loading_data", DataState != WidgetDataState.Unknown);

Because the WidgetDataState enum has the following possible states:
Image
So if the state becomes Okay the widget would still show loading content...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working or needs investigation Needs-Triage New issue that the core contributors need to triage
Projects
None yet
Development

No branches or pull requests

1 participant