Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to toggle web sockets in app services #2512

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ilnarag
Copy link

@ilnarag ilnarag commented Nov 20, 2024

Added methods to enable/disable web sockets on App Services

@Flanker32 Flanker32 requested a review from Copilot December 22, 2024 02:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

azure-toolkit-libs/azure-toolkit-appservice-lib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/webapp/WebAppDeploymentSlot.java:42

  • Ensure that the behavior introduced by the toggleWebSockets method is covered by tests.
doModify(() -> Objects.requireNonNull(getRemote()).update().withWebSocketsEnabled(enabled).apply(), Status.UPDATING);
@ilnarag
Copy link
Author

ilnarag commented Jan 17, 2025

We have decided to implement it on our side first: JetBrains/azure-tools-for-intellij#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant