Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o-my-posh theme slightly broken #766

Open
imSamiul opened this issue Sep 2, 2024 · 9 comments
Open

o-my-posh theme slightly broken #766

imSamiul opened this issue Sep 2, 2024 · 9 comments

Comments

@imSamiul
Copy link

imSamiul commented Sep 2, 2024

Cascadia family version

2404.23

Cascadia family variant(s)

Cascadia Code (the version with ligatures)

Font file format(s)

.ttf (variable)

Platform

Windows

Other Software

Windows Terminal

What happened?

Screenshot 2024-09-02 135205
Here o-my-posh theme icon is slightly broken on new released Cascadia Code 2404.23 Nerd Font.

@o-l-a-v
Copy link

o-l-a-v commented Sep 2, 2024

Do you have an example of a font where it's not broken like that?

@imSamiul
Copy link
Author

imSamiul commented Sep 2, 2024

Do you have an example of a font where it's not broken like that?

Fira Code Nerd Font Mono

image

@o-l-a-v

@o-l-a-v
Copy link

o-l-a-v commented Sep 2, 2024

I can't reproduce. Tried Cascadia Mono NF and Cascadia Code NF.

image

@imSamiul
Copy link
Author

imSamiul commented Sep 2, 2024

@o-l-a-v it gets fixed when the font size increased. Try using lower the font size of windows terminal then use get-PoshThemes. some themes are broken. to be specific when the font size is 12

@o-l-a-v
Copy link

o-l-a-v commented Sep 2, 2024

I used font size 12 in those screenshots and zoomed in. I also tried Get-PoshThemes. I can't reproduce with the steps you've provided. So maybe you should do some more research into what conditions causes this.

@aaronbell
Copy link
Collaborator

Not to say that there isn’t something else going on here, but it is challenging to identify exactly the problem due to the differing factors involved. Namely the way that a given rendering environment implements the highlighting, the way the OS text rasterizer positions the end cap, the resolution of your monitor, zoom amount, etc etc.

I think that the next version of Cascadia will sort this out but hard to say for certain.

@imSamiul
Copy link
Author

imSamiul commented Sep 2, 2024

My problem is kind of wierd. My themes get broken only on even number of font size like 10,12,14... 16 is good. don't know what happed. 11,13,15 are good. hard to find out the problem. I use windows 11, my laptop resolution is 1920x1080 with 125% zoom 15.6 inch display. maybe it pixer rendering issue. not sure. any information that you need i can provide. Hope for the better version of Cascadia.

@aaronbell
Copy link
Collaborator

Yeah, that’s kind of how this thing goes. Some sizes are perfect, others aren’t. Hard to predict!

@DHowett
Copy link
Member

DHowett commented Sep 4, 2024

It is worth noting that new versions of Windows Terminal (1.20 and above) take over the following powerline shapes, and draw them "perfectly". This means that if you are using Cascadia with these versions Windows Terminal, you should not experience rounding errors like this.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants