Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0010] Feature availability check #40

Closed
llvm-beanz opened this issue Apr 14, 2023 · 1 comment · Fixed by #54
Closed

[0010] Feature availability check #40

llvm-beanz opened this issue Apr 14, 2023 · 1 comment · Fixed by #54
Labels
active proposal Issues relating to active proposals

Comments

@llvm-beanz
Copy link
Collaborator

Which proposal does this relate to?
0010-vk-buffer-ref.md

Describe the issue or outstanding question.
Since this is a retroactive feature, we should document and describe a feature availability check using the clang __has_feature infrastructure in DXC. We haven't historically used this for features, but it is much nicer than forcing users to key off specific compiler versions and I've locally tested that it is fully functional in DXC.

Additional context
See initial review discussion.
@llvm-beanz llvm-beanz added the active proposal Issues relating to active proposals label Apr 14, 2023
@greg-lunarg
Copy link
Contributor

I propose the following syntax: _has_feature(hlsl_vk_buffer_pointer)

greg-lunarg added a commit to greg-lunarg/hlsl-specs that referenced this issue May 5, 2023
@greg-lunarg
Add feature check for vk::BufferPointer
d8cfd99 
Fixes microsoft#40
greg-lunarg added a commit to greg-lunarg/hlsl-specs that referenced this issue May 5, 2023
@greg-lunarg
Add feature check for vk::BufferPointer
8d1f9b1 
Fixes microsoft#40
@greg-lunarg greg-lunarg mentioned this issue May 5, 2023
Merged
llvm-beanz added a commit that referenced this issue Sep 1, 2023
@greg-lunarg @llvm-beanz
Add feature check for vk::BufferPointer (#54)
256acd3 
* Add feature check for vk::BufferPointer

Fixes #40

* Fix typo.

---------

Co-authored-by: Chris B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
active proposal Issues relating to active proposals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature check for vk::BufferPointer greg-lunarg/hlsl-specs
2 participants
@greg-lunarg @llvm-beanz