From 466ca3bbb8b60ce5eb9e2bff9fb1e9d9ce3f6034 Mon Sep 17 00:00:00 2001
From: r-dailey <108893075+r-dailey@users.noreply.github.com>
Date: Fri, 13 Dec 2024 13:16:21 -0800
Subject: [PATCH] Marked all sockperf tests to skip (#3556)

* MArked all sockperf tests to be skipped
---
 microsoft/testsuites/performance/networkperf.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/microsoft/testsuites/performance/networkperf.py b/microsoft/testsuites/performance/networkperf.py
index 2ed386cee0..adb014b1ec 100644
--- a/microsoft/testsuites/performance/networkperf.py
+++ b/microsoft/testsuites/performance/networkperf.py
@@ -286,6 +286,12 @@ def perf_udp_iperf_sriov(self, result: TestResult) -> None:
             udp_mode=True,
         )
 
+    # Marked all following tests to skip on BSD since
+    # sockperf compilation is not natively supported at this time
+    # This is due to the default compiler on freebsd being c++17
+    # and sockperf is designed to compile on c+11 which is no longer available
+    # This is a way to compile it but it requires adding a patch file
+    # to the sockperf repo to remove references to std::unary and std::binary
     @TestCaseMetadata(
         description="""
         This test case uses sockperf to test sriov network latency.
@@ -294,6 +300,7 @@ def perf_udp_iperf_sriov(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Sriov(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_tcp_sriov(self, result: TestResult) -> None:
@@ -307,6 +314,7 @@ def perf_sockperf_latency_tcp_sriov(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Sriov(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_udp_sriov(self, result: TestResult) -> None:
@@ -320,6 +328,7 @@ def perf_sockperf_latency_udp_sriov(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Synthetic(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_udp_synthetic(self, result: TestResult) -> None:
@@ -333,6 +342,7 @@ def perf_sockperf_latency_udp_synthetic(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Synthetic(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_tcp_synthetic(self, result: TestResult) -> None:
@@ -346,6 +356,7 @@ def perf_sockperf_latency_tcp_synthetic(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Sriov(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_tcp_sriov_busy_poll(self, result: TestResult) -> None:
@@ -364,6 +375,7 @@ def perf_sockperf_latency_tcp_sriov_busy_poll(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Sriov(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_udp_sriov_busy_poll(self, result: TestResult) -> None:
@@ -382,6 +394,7 @@ def perf_sockperf_latency_udp_sriov_busy_poll(self, result: TestResult) -> None:
         requirement=simple_requirement(
             min_count=2,
             network_interface=Synthetic(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_udp_synthetic_busy_poll(self, result: TestResult) -> None:
@@ -400,6 +413,7 @@ def perf_sockperf_latency_udp_synthetic_busy_poll(self, result: TestResult) -> N
         requirement=simple_requirement(
             min_count=2,
             network_interface=Synthetic(),
+            unsupported_os=[BSD, Windows],
         ),
     )
     def perf_sockperf_latency_tcp_synthetic_busy_poll(self, result: TestResult) -> None: