[Bug]: FlattenPdbs not copying any files

[jorticus-msft]

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

In #511, FlattenPdbs was modified to only include PDBs from the OUTPUT folder. However my build for whatever reason puts the PDB in the folder outside of this (plus the DEBUG folder), but not the OUTPUT folder, so no PDBs are getting copied to the PDB flat directory.

ie, my directory structure looks like this:

 DxeMain
 ├╴DEBUG
 │ ├╴AutoGen.c
 │ ├╴AutoGen.h
 │ ├╴DxeCore.dll
 │ ├╴DxeCore.efi
 │ ╰╴DxeCore.map
 ├╴OUTPUT
 │ ├╴AutoGen.c.deps
 │ ├╴AutoGen.obj
 │ ├╴DxeCore.depex
 │ ├╴DxeCore.efi
 │ ├╴DxeCore.inf
 │ ├╴DxeCore.lib
 │ ├╴DxeCore.map
 │ ├╴DxeCore.txt
 │ ├╴DxeCore.uni
 │ ├╴DxeCoreExtra.uni
 │ ├╴object_files.lst
 │ ╰╴static_library_files.lst
 ├╴AutoGenTimeStamp
 ├╴dependency
 ├╴deps.txt
 ├╴deps_target
 ├╴DxeCore.makefile
 ├╴DxeCore.pdb   <-- This should be copied out
 ╰╴Makefile

Suggested fix:

       logging.critical("Copying PDBs to flat directory")

       symbols = set()
       for file in Path(build_path).rglob("*.pdb"):
           pdb_out = Path(pdb_path / file.name)

           # Skip MSVC symbols
           if "vc1" in file.name.lower():
               continue

           # Deduplicate
           if not file.name in symbols:
               symbols.add(file.name)

               # If it exists and has the same file identifier, skip it.
               if pdb_out.exists() and file.stat().st_ino == pdb_out.stat().st_ino:
                   continue

               # Hard link it, which is slightly faster, but mainly allows us to tell
               # if the file has changed (st_ino is different)
               pdb_out.unlink(missing_ok=True)
               pdb_out.hardlink_to(file)

       if not symbols:
           logging.error('No symbols were copied')
           return -1

       return 0

Expected Behavior

PDBs should be copied under $BuildOutput\PDB.

Steps To Reproduce

Build platform, observe no symbols copied to PDB folder.

Build Environment

- OS(s): Windows 11
- Tool Chain(s): VS2022
- Targets Impacted: All

Version Information

5658e8a1f82238bfa2059f82f58699f7f3dcb8f3

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response