Included end tag in HTML folding range #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We'd need an option for that as we don't want to lose the existing behavior What if there's more content after the closing tag? |
|
How would one go about adding a setting to this? Would this be on the vscode client side or added here? |
AlexXuChen
force-pushed
the
folding-range-with-end-tag
branch
from
861f79c to
59a19cc
Compare
|
Yes there's also a new setting needed in the JSON language extension. That is in https://github.com/microsoft/vscode. Can you add a test case where the closing tag is on the same line as the next opening tag? |
Signed-off-by: Alexander Chen <[email protected]>
AlexXuChen
force-pushed
the
folding-range-with-end-tag
branch
from
59a19cc to
afed461
Compare
|
closing, PR hasn't been worked on for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included end tag in HTML folding range
Fixes #126
Signed-off-by: Alexander Chen [email protected]