Adding a folder to an Empty workspace seems to try to re-activate every extension

[TylerLeonhardt]

Does this issue occur when all extensions are disabled?: N/A

Version: 1.57.0-insider
Commit: 20df877
Date: 2021-06-03T06:00:36.788Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.5.0

Steps to Reproduce:

1. Open an empty workspace
2. Add a folder to the workspace via: Workspace: Add folder to workspace...
3. Open dev tools and see a sea of red:
   

This doesn't repro if the workspace is just a normal folder.

[lszomoru]

@TylerLeonhardt, I am unable to reproduce the issue in Insiders and OSS.
Could you record a GIF as I have the feeling I am missing something. Thanks!

[TylerLeonhardt]

I am adding a workspace that is trusted to an Empty Workspace… maybe that’s the key?

[sbatten]

I could reproduce this with a trusted folder being added to a restricted mode empty workspace. However, I could only do so in Insiders but not in OSS. Did anything change in the last 24h?

[bpasero]

See #69335

[lszomoru]

@bpasero, I am not seeing any commit from the last 24 hours linked on that issue.

[bpasero]

@lszomoru yeah just wanted to point out why the extension host restarts. This has been like that since the beginning of multi root workspaces.

[lszomoru]

Got it. I was aware of the extension host restart.
Trying to figure out what changed in the last 24 hours that fixed the issue reported by @TylerLeonhardt

[lszomoru]

I got it to repro in Insiders but it does not repro in OSS. Will investigate the issue and try to get to the bottom of it.