Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figures shown up seems odd #346

Closed
gh279760559 opened this issue Aug 11, 2023 · 12 comments
Closed

Figures shown up seems odd #346

gh279760559 opened this issue Aug 11, 2023 · 12 comments

Comments

@gh279760559
Copy link

Screenshot_20230811_114935

Hi, 1st of all thanks for providing a such awesome tool. I got few questions/issues regarding figures showup in the article:

  1. please check green marks, odd square brackets (I assume it is kinda like ![]?)
  2. a big space between the figure and the corresponding online link
    So please help remove these.

another questions, do we have options to

  1. disable online figures download and only use online links instead
  2. use local figures and disable online links track

Thanks!

@mika-cn
Copy link
Owner

mika-cn commented Aug 11, 2023

  1. please check green marks, odd square brackets (I assume it is kinda like ![]?)
  2. a big space between the figure and the corresponding online link
    So please help remove these.

Same as #344


another questions, do we have options to

  1. disable online figures download and only use online links instead
  2. use local figures and disable online links track

Currently, we are not considering using online figures. What's your use case? Is it not better to download them?

And what do you mean "disable online links track", There'll be not online figure links after the clipping.

@gh279760559
Copy link
Author

gh279760559 commented Aug 11, 2023

  1. please check green marks, odd square brackets (I assume it is kinda like ![]?)
  2. a big space between the figure and the corresponding online link
    So please help remove these.

Same as #344


another questions, do we have options to

  1. disable online figures download and only use online links instead
  2. use local figures and disable online links track

Currently, we are not considering using online figures. What's your use case? Is it not better to download them?

And what do you mean "disable online links track", There'll be not online figure links after the clipping.

thx for the reply.

in short I want to get online links instead and download them using the obsidian plugin which is a convenient way for me. Or it would be better that all figures are downloaded automatically without those weird space between [] which requires lots of manual works actually. (thx for pointing out the similar issue then, so it remains unsolved, does it)

"There'll be not online figure links after the clipping."--Interesting please check the link after the red mark area which is exact online figure link shown above.

@gh279760559
Copy link
Author

from #344 I can tell it is because of the turndown js lib issue. Just curious if there is a way to remove space and square brackets themselves.

@mika-cn
Copy link
Owner

mika-cn commented Aug 11, 2023

in short I want to get online links instead and download them using the obsidian plugin which is a convenient way for me. Or it would be better that all figures are downloaded automatically without those weird space between [] which requires lots of manual works actually. (thx for pointing out the similar issue then, so it remains unsolved, does it)

No, it'll get solved, these weird spaces around the image should be removed.

"There'll be not online figure links after the clipping."--Interesting please check the link after the red mark area which is exact online figure link shown above.

The link you saw actually is a hyper link (that represent a image).

@mika-cn
Copy link
Owner

mika-cn commented Aug 11, 2023

By the way, to download these images with markdown, the best place to do it is on the browser. Because browser has the user environment such as cookie, token etc. So if you want to use Obsidian plugin to download online image inside markdown file, there's some rare cases that you failed to download these images, because the web server check the user environment.

@mika-cn
Copy link
Owner

mika-cn commented Aug 12, 2023

The issue should be fixed on version 0.4.37, please update your extnsion.

@gh279760559
Copy link
Author

gh279760559 commented Aug 12, 2023

No, it'll get solved, these weird spaces around the image should be removed.

thx to letting me know when it is solved. Tbh it requires lots of manual works currently to remove those things.

@gh279760559
Copy link
Author

The issue should be fixed on version 0.4.37, please update your extnsion.

Super! So efficient, thank you!

@gh279760559
Copy link
Author

update:
nearly perfect! Just one small thing--there is still one space and one right square bracket.
Screenshot_20230812_115245.png

@mika-cn
Copy link
Owner

mika-cn commented Aug 13, 2023

Aha, this must be a new case, thanks for the update. Please post the URL of the article you clipped for further investigation.

@gh279760559
Copy link
Author

Aha, this must be a new case, thanks for the update. Please post the URL of the article you clipped for further investigation.

check it out:https://magazine.sebastianraschka.com/p/ahead-of-ai-10-state-of-computer

@mika-cn
Copy link
Owner

mika-cn commented Aug 14, 2023

The new case is cause by a blole element that has blank content, it will be converted to \n\n by default through Turndown.

I've fix this on version 0.4.38, please update.

@mika-cn mika-cn closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants