Pre iOS 13 devices fail to deallocate BSImagePicker after it has been dismissed

[gams95]

I notice that when BSImagePicker was dismissed, BSImagePicker does not deallocate even though the presentingViewController has bee deallocated (deinit). This only happens on devices running pre iOS 13. As a workaround, i changed the modalPresentationStyle of BSImagePicker to .currentContext Even though it manages to fix this issue, however i do not know if this is the right way of fixing this issue. Any thoughts on this?

[mikaoj]

Nice, sounds like it is related to #271.

Have you tried any of the other presentation styles too and found that it is only .currentContext that works?

[gams95]

In my implementation:

1. I set imagePickerController as optional in my viewController.
2. I don't use the closure and implement the ImagePickerDelegate on my own viewcontroller
3. Before dismissing, i set the imagePickerController as nil

Based on above implementation, only .currentContext deallocate properly after the viewcontroller has been dismissed.

[nesteralready]

iOS 14.7 same issue. I tried to fix by myself, but the only thing that I understood - it's the problem in method "presentImagePicker" cause after removing it and presenting just like " vc.present(imagePicker, animated: true)" memory leak is never happened.

[tiper]

The issue seems to be caused by the ImagePickerController when on the viewDidLoad it sets the presentationController.delegate to self. However, invoking imagePicker.presentationController before calling presentImagePicker seems to fix the issue.

let imagePicker = ImagePickerController()
...
<image picker configurations here>
...
_ = imagePicker.presentationController
controller.presentImagePicker(imagePicker, animated: true, select: nil, deselect: nil, cancel: nil, finish: nil, completion: nil)

[jdleung]

The issue seems to be caused by the ImagePickerController when on the viewDidLoad it sets the presentationController.delegate to self. However, invoking imagePicker.presentationController before calling presentImagePicker seems to fix the issue.

let imagePicker = ImagePickerController()
...
<image picker configurations here>
...
_ = imagePicker.presentationController
controller.presentImagePicker(imagePicker, animated: true, select: nil, deselect: nil, cancel: nil, finish: nil, completion: nil)

It doesn't work on my end, the memory consumption still increases every time when clicking into imagePicker.