Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing bacon to rspec #60

Closed
junaruga opened this issue May 2, 2018 · 7 comments · Fixed by #62
Closed

Changing bacon to rspec #60

junaruga opened this issue May 2, 2018 · 7 comments · Fixed by #62

Comments

@junaruga
Copy link
Contributor

junaruga commented May 2, 2018

Right now this project is using the small RSpec clone bacon.
But the problem is that bacon project stopped the development [1].
I wanted to fix a issue for that in a past time. But I could not.

So, I think changing this project's testing framework from bacon to rspec would be better.
If you like it, I can contribute for that.

[1] leahneukirchen/bacon#32

@junaruga
Copy link
Contributor Author

junaruga commented May 2, 2018

Or changing to minitest.
Nowadays minitest or rspec are popular.
But in this case. changing bacon to rspec is easier.
How do you think?

@minad
Copy link
Collaborator

minad commented May 2, 2018

Hey Jun,

you are right about bacon. How much are you interested in this gem? If you want to become a co-maintainer, please let me know :) Unfortunately I don't have much time to maintain it right now.

Daniel

@minad
Copy link
Collaborator

minad commented May 2, 2018

@junaruga Ah you already wrote that you would like to contribute it, is it ok if I add you to the repository?

@junaruga
Copy link
Contributor Author

junaruga commented May 2, 2018

@minad Yes, okay, I am happy to be the co-maintainer.
Because mimemagic is a part of Rails 5.2.0 runtime dependency now.
I am working to release Rails 5.2.0 gem for Fedora Project.
That's my motivation :)

@minad
Copy link
Collaborator

minad commented May 2, 2018

Ah I see. I will add you to the repository. You might also want to look at some of the open issues if you have time. Concerning the test framework I would probably prefer minitest over rspec since it seems less heavy etc, but you can decide.

@junaruga
Copy link
Contributor Author

junaruga commented May 2, 2018

@minad okay, I am fine to use minitest. That makes sense. I will send PR after fixing it.
Okay, I will see the issue.

@minad
Copy link
Collaborator

minad commented May 2, 2018

Ok cool!

@minad minad closed this as completed in #62 May 3, 2018
@mimemagicrb mimemagicrb locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants