Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend data manager to read Pokemon Showdown! files #13

Closed
mirekdlugosz opened this issue Jul 1, 2018 · 2 comments
Closed

Extend data manager to read Pokemon Showdown! files #13

mirekdlugosz opened this issue Jul 1, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@mirekdlugosz
Copy link
Owner

Pokémon Showdown! is exhaustive source of information about Pokémon games since gen III. It has two advantages over veekun:

  • Bigger community, meaning faster support for new games
  • Movesets include event moves

It would be great if our data-manager could support Pokémon Showdown! files as data sources.

For starters, it could use Pokémon Showdown! as only source of data. Eventually it should be able to read veekun data and add missing pieces from Pokémon Showdown!.

Pokémon Showdown! data is held in JavaScript arrays that are not readable by standard JSON parsers. It must be first transformed to JSON. See data-manager/data-source/js-to-json.sh in ac3d664 for one way to transform it.

Both Pokémon and move names differ a little between veekun and Pokémon Showdown!. Some way to transform names from one space to another must be found. Similar problem must be solved as part of Issue #9. It would be really cool if we could find a way to solve both without code duplication.

@mirekdlugosz mirekdlugosz added the help wanted Extra attention is needed label Jul 1, 2018
@mirekdlugosz
Copy link
Owner Author

Implemented while working on "Prepare for Sword and Shield".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant