Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down list of Pokemon to choose from #16

Open
mirekdlugosz opened this issue Jul 2, 2018 · 0 comments
Open

Narrow down list of Pokemon to choose from #16

mirekdlugosz opened this issue Jul 2, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mirekdlugosz
Copy link
Owner

Reddit user Sayakai writes:

This (...) seems to be less than ideal for any case where you're still trying to build a team, and haven't decided on team members yet, there's no option to exclude Pokemon from the long list based on parameters.

  • type
  • resists x
  • NOT type
  • NOT weak to x

Those would be the primary ones coming to mind. It would be helpful if those could be set as a list of flags or tags, or something like that.

I agree that the "when" question would be very helpful, and I think the key here is "before gym #x". That's fairly uniform until gen 6. Gen 7 is harder to implement, though here separating per island would probably work.

Idea is great, what we lack is design (what forms should we display? where? do we put user choices in URL somehow, or not? what if user choices are contradictory or no Pokemon actually meets all the criteria?) and manpower to implement it.

It makes perfect sense for me to tackle search dimensions (type, resists X etc.) one at the time. "When" is whole different game, probably with lower priority.

Testing ideas:

  • make sure that selections do not affect already selected Pokemon
  • what if form would give empty results in other game? what if form doesn't make sense in other game (e.g. search for Dark Pokemon and switch to Yellow)?
  • does it handle type chart changes across games? Pokemon that changed types?
  • does selection affect every Pokemon selector (when clicked)? Non-empty? First non-empty? First in unbroken stream of non-empty?
  • Pokemon with one type, with first type and with secondary type selected in different fields
@mirekdlugosz mirekdlugosz added enhancement New feature or request help wanted Extra attention is needed labels Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant