Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for moves using their own type chart #4

Open
mirekdlugosz opened this issue Jul 1, 2018 · 0 comments
Open

Add support for moves using their own type chart #4

mirekdlugosz opened this issue Jul 1, 2018 · 0 comments

Comments

@mirekdlugosz
Copy link
Owner

Since gen VI, there are now moves that use non-standard type effectiveness chart. As of now, they are: Flying Press, Freeze-Dry and Thousand Arrows (see current list on Bulbapedia). We do not support them, treating them as normal moves of their types.

We already have stub of move properties overriding mechanism in place - we use it to change type of move depending on current game version. It should be generalized for this feature.

Overrides should be generated on data manager level and then processed in frontend. Code pointers:

  • data-manager/pokedexreader/constants.py
  • src/app/services/typeeffectiveness.service.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant