Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation] CreateReactApp Complex Inline Method Refactoring #136

Open
mkshiblu opened this issue Feb 8, 2022 · 1 comment
Open

[Validation] CreateReactApp Complex Inline Method Refactoring #136

mkshiblu opened this issue Feb 8, 2022 · 1 comment
Labels
InterestingTestCase test-case-validation

Comments

@mkshiblu
Copy link
Owner

mkshiblu commented Feb 8, 2022 •
edited
Loading

Reported By JSExtension

Inline Method render() inlined to updateIframeContent() at packages/react-error-overlay/src/index.js|updateIframeContent

image

image

Reported By RefDiff

EXTRACT_MOVE Function packages/react-error-overlay/src/index.js:4289-4885 updateIframeContent packages/react-error-overlay/src/iframeScript.js:1040-1329 updateContent    
MOVE Function packages/react-error-overlay/src/index.js:3777-4287 render packages/react-error-overlay/src/iframeScript.js:534-1015 render    

Project; https://github.com/refdiff-study/create-react-app

Commit: cd3d04b71e91f533bdbdc3856775e1da81d445cf
@mkshiblu
Copy link
Owner Author

mkshiblu commented Feb 8, 2022

@tsantalis What type of refactoring should this fall into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
InterestingTestCase test-case-validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkshiblu