Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoCm support #445

Open
fxmarty opened this issue Sep 5, 2023 · 2 comments · May be fixed by #490
Open

RoCm support #445

fxmarty opened this issue Sep 5, 2023 · 2 comments · May be fixed by #490
Labels
enhancement New feature or request P1 Priority 1

Comments

@fxmarty
Copy link

fxmarty commented Sep 5, 2023

  • CodeCarbon version: main
  • Python version: all
  • Operating System: Linux

Description

It would be great to add RoCm support to codecarbon. For now, codecarbon requires and depends on pynvml, that is an interface only for Nvidia GPUs. However, using AMD GPUs is becoming easier and easier, and we can expect some researchers to make the switch from Nvidia.

A WIP alternative for RoCm seem to be https://github.com/RadeonOpenCompute/pyrsmi

I could possibly submit a PR if there is interest.
@benoit-cty
Copy link
Contributor

Hello,
Thank you, I will be happy to help you made a PR for this.
You have to modify https://github.com/mlco2/codecarbon/blob/master/codecarbon/core/gpu.py.

@benoit-cty benoit-cty added the enhancement New feature or request label Sep 13, 2023
@IlyasMoutawwakil
Copy link

@fxmarty @benoit-cty I was able to perform all pynvml operations in gpu.py using amd-smi, pyrsmi lacks a lot of the metrics, I will submit a PR.

@IlyasMoutawwakil IlyasMoutawwakil linked a pull request Jan 16, 2024 that will close this issue
Open
@benoit-cty benoit-cty linked a pull request Feb 9, 2024 that will close this issue
[Version 3] AMD GPUs support #490
Open
@benoit-cty benoit-cty added the P1 Priority 1 label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P1 Priority 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Version 3] AMD GPUs support IlyasMoutawwakil/codecarbon
3 participants
@benoit-cty @fxmarty @IlyasMoutawwakil