Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit 4.0-based app to Apple App Store #780

Open
2 tasks
freedomtan opened this issue Sep 12, 2023 · 40 comments
Open
2 tasks

Submit 4.0-based app to Apple App Store #780

freedomtan opened this issue Sep 12, 2023 · 40 comments
Milestone
Play Store

Comments

@freedomtan
Copy link
Contributor

freedomtan commented Sep 12, 2023 •
edited
Loading

Let's check what need to be done before submitting to App Store

  • screenshots
  • requirement 2

And then submit it.
@freedomtan
Copy link
Contributor Author

ask @nathanw-mlc for the App Store account

@nathanw-mlc
Copy link
Member

Anh already has access to the App Store accounts. Will anyone else need access?

@RSMNYS
Copy link
Contributor

RSMNYS commented Sep 13, 2023

Hi guys! We need screenshots with such sizes:

Screenshot 2023-09-13 at 14 39 06

Based on this: https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications

6.5":

iPhone 14 Plus
iPhone 13 Pro Max
iPhone 12 Pro Max
iPhone 11 Pro Max
iPhone 11
iPhone XS Max
iPhone XR

5.5":

iPhone 8 Plus
iPhone 7 Plus
iPhone 6s Plus

Unfortunately we can't make the screenshots from the simulators as it has Debug label on the screen, and such screenshots are not acceptable. So we need to find these devices to prepare the screenshots for the submission.

@RSMNYS
Copy link
Contributor

RSMNYS commented Sep 13, 2023

Actually it's possible to remove that label for the debug flutter mode.
Simulator Screenshot - iPhone 14 Pro Max - 2023-09-13 at 15 00 42

Let me know if I should prepare all screenshots and upload to the App Store. My email is: [email protected].

@anhappdev
Copy link
Collaborator

Anh already has access to the App Store accounts. Will anyone else need access?

@nathanw-mlc Please assign @RSMNYS a role so he can prepare the app for the App Store release. Thank you.

@nathanw-mlc
Copy link
Member

@RSMNYS What Apple ID email address should I use to grant you access to the App Store? If you don't want to post it publicly in this thread, you can email [email protected].

@RSMNYS
Copy link
Contributor

RSMNYS commented Sep 14, 2023

[email protected]. Thank you

@nathanw-mlc
Copy link
Member

Thanks, invitation sent.

@RSMNYS
Copy link
Contributor

RSMNYS commented Sep 16, 2023

@RSMNYS What Apple ID email address should I use to grant you access to the App Store? If you don't want to post it publicly in this thread, you can email [email protected].

@nathanw-mlc please change my role to the app manager, with the developer role I'm not able to upload the screenshots.

Thanks

@nathanw-mlc
Copy link
Member

@RSMNYS, I've updated your role as requested.

@RSMNYS
Copy link
Contributor

RSMNYS commented Sep 18, 2023

Screenshot 2023-09-18 at 21 42 30 Screenshot 2023-09-18 at 21 42 49

@nathanw-mlc
Copy link
Member

Do we want screenshots with the blue background of the official release, since presumably that's what people will be downloading? If you need, I can provide them.

@anhappdev
Copy link
Collaborator

https://developer.apple.com/app-store/app-privacy-details/

@freedomtan
Copy link
Contributor Author

freedomtan commented Sep 19, 2023 •
edited
Loading

  • privacy policy statement: how user-generated data are treated (where are they stored, how they are to be used by MLCommons), etc. https://developer.apple.com/app-store/app-privacy-details/
  • app description: short and long description
  • test accounts: pre-created accounts for Apple to test? or ask them to create accounts in the App?
    • we have to create accounts for them before submission

@TheKanter and @peladodigital

@freedomtan
Copy link
Contributor Author

@Mostelk let's try to discuss the privacy policy statement issue in the working group policy meeting.

@freedomtan
Copy link
Contributor Author

iphone 15 Pro Max iPhone 14 Pro iPhone 13

@freedomtan
Copy link
Contributor Author

An example result.json file on iPhone 13.

Currently, besides benchmark numbers, what we collected in the app are:

{
  ...,
  "environment_info": {
    "platform": "ios",
    "value": {
      "android": null,
      "ios": {
        "os_version": "Version 17.0.1 (Build 21A340)",
        "model_code": "iPhone14,5",
        "model_name": "iPhone 13",
        "soc_name": "Apple A15"
      },
      "windows": null
    }
  },
  "build_info": {
    "version": "3.1.0",
    "build_number": "1",
    "build_date": "2023-09-22T16:56:43.134131",
    "official_release_flag": false,
    "dev_test_flag": false,
    "backend_list": [
      "libcoremlbackend",
      "libtflitebackend"
    ],
    "git_branch": "ndk_25_quick_hack",
    "git_commit": "73942b6a1a725972d6f9f6390dd4315f9c663a0b",
    "git_dirty_flag": true
  }
}

@peladodigital
Copy link

@RSMNYS Please go ahead with these for the configuration of the store. We can go with this and then later add if needed

@RSMNYS
Copy link
Contributor

RSMNYS commented Nov 7, 2023

@RSMNYS Please go ahead with these for the configuration of the store. We can go with this and then later add if needed

@peladodigital I think you've missed the original request. Let me share it again. To submit the app to the store we need to check and fill the next points:

  • privacy policy statement: how user-generated data are treated (where are they stored, how they are to be used by MLCommons), etc. https://developer.apple.com/app-store/app-privacy-details/
  • app description: short and long description
  • test accounts: pre-created accounts for Apple to test? or ask them to create accounts in the App?
    we have to create accounts for them before submission

@peladodigital can you help with this please?

Here is the link to the app store: https://appstoreconnect.apple.com/apps/1629525778/appstore/privacy

@freedomtan
Copy link
Contributor Author

@TheKanter and @peladodigital Please help provide the privacy policy statement, c.f. https://developer.apple.com/app-store/app-privacy-details/.

@RSMNYS please pick one from TestFlight.

@TheKanter
Copy link
Contributor

TheKanter commented Nov 14, 2023 via email

@anhappdev
Copy link
Collaborator

I'm working to get one generated for us. Do you have any examples I can share with our attorneys? Ideally a simple one.

@TheKanter You may use one of the templates from:
https://termly.io/products/privacy-policy-generator/

@freedomtan
Copy link
Contributor Author

maybe we need both "terms of use" / "EULA" and "privacy policy"

@TheKanter
Copy link
Contributor

TheKanter commented Nov 22, 2023 via email

@freedomtan
Copy link
Contributor Author

@RSMNYS and @anhappdev can we submit the iOS app to mac app store? Or we need native macOS UI?

@anhappdev
Copy link
Collaborator

@RSMNYS and @anhappdev can we submit the iOS app to mac app store? Or we need native macOS UI?

Yes, we can but the app will work only on Mac computers with Apple silicon (M1, M2, ...)
https://support.apple.com/en-vn/guide/app-store/fird2c7092da/mac

@TheKanter
Copy link
Contributor

TheKanter commented Nov 28, 2023 via email

@freedomtan
Copy link
Contributor Author

Let's enable macOS compatibility for TestFlight, then we can test the app on both iOS and macOS (apple silicon machines)

@TheKanter
Copy link
Contributor

TheKanter commented Nov 28, 2023 via email

@anhappdev
Copy link
Collaborator

The app should be already available on TestFlight for Mac (https://apps.apple.com/us/app/testflight/id899247664)

@freedomtan
Copy link
Contributor Author

@@RSMNYS please check if you got the term of use and privacy policy docs. If yes, let's try to make this into the app store.

@freedomtan to check if those docs are available to @RSMNYS and @anhappdev.

@freedomtan
Copy link
Contributor Author

open source:
TensorFlow: include TensorFlow's apache license
models: apache license should be enough

@freedomtan to crease an issue to track this and check open source third-party libraries we used. Check other benchmark programs.

vendor spec (for Android):

  • SNPE: binary libraries included, should be OK to re-distributed, @mohitmundhragithub will help check that
  • Samsung: binaries should be fine, @Mostelk

@anhappdev
Copy link
Collaborator

@RSMNYS Since we have a new design for v4.0, can you please update the screenshots in the App Store Connect?

@anhappdev anhappdev changed the title Submit 3.1-based app to Apple App Store Submit 4.0-based app to Apple App Store May 28, 2024
@RSMNYS
Copy link
Contributor

RSMNYS commented May 31, 2024 •
edited
Loading

@anhappdev are those screenshots correct? I'm using the v4.0 branch, official_build, but see a bunch of UI issues as below. Where we use black text on blue background, and other components also looks wrong and visibility is bad. Please let me know.

Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 10 52

Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 05 40
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 05 45
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 15 46

@anhappdev
Copy link
Collaborator

@anhappdev are those screenshots correct? I'm using the v4.0 branch, official_build, but see a bunch of UI issues as below. Where we use black text on blue background, and other components also looks wrong and visibility is bad. Please let me know.

I am not sure why your build looks different, maybe you used a different Flutter SDK version?
For iOS, can you use the version 4.0 (build 125) from TestFlight? The UI looks correct on my iPhone with the build from TestFlight.

@RSMNYS
Copy link
Contributor

RSMNYS commented May 31, 2024

You're right @anhappdev. Now have everything looks good. By the way, we can use the fvm to manage the flutters versions, and lock the flutter version for the project. So everyone can use the same version of the flutter sdk. What do you think?

@anhappdev
Copy link
Collaborator

You're right @anhappdev. Now have everything looks good. By the way, we can use the fvm to manage the flutters versions, and lock the flutter version for the project. So everyone can use the same version of the flutter sdk. What do you think?

We have already defined the Flutter SDK version in the pubspec.yml file. And we don't change the Flutter SDK version often, so I am not sure if we need yet another tool.

@anhappdev
Copy link
Collaborator

@RSMNYS Please also upload screenshots for iPad.

The items below are required to start the review process:
You must upload a screenshot for 12.9-inch iPad Pro (2nd generation) displays.
You must upload a screenshot for 13-inch iPad displays.

@anhappdev
Copy link
Collaborator

@nathanw-mlc Can you help resolve this one?

The items below are required to start the review process:
Under the Digital Services Act, you must provide and verify information regarding your account. Learn More

@RSMNYS
Copy link
Contributor

RSMNYS commented Jun 3, 2024

@RSMNYS Please also upload screenshots for iPad.

The items below are required to start the review process:
You must upload a screenshot for 12.9-inch iPad Pro (2nd generation) displays.
You must upload a screenshot for 13-inch iPad displays.

done

@anhappdev anhappdev added this to the Play Store milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Play Store
Development

No branches or pull requests
6 participants
@freedomtan @RSMNYS @TheKanter @anhappdev @peladodigital @nathanw-mlc