Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quick run mode #941

Merged
merged 4 commits into from
Jan 14, 2025
Merged

feat: add quick run mode #941

merged 4 commits into from
Jan 14, 2025

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Dec 28, 2024

  • The "Integration Test Run" mode will be hidden from user. I just show it here for debug purpose.
  • The cool down duration slider will be updated when the user change the run mode. But the duration can still be manually changed by the user.
  • The other settings (min_query_count, min_duration, max_duration) are defined in the tasks.pbtxt file and cannot be changed by the user.

Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Comment on lines +10 to +26
runs {
normal {
min_query_count: 1024
min_duration: 60
max_duration: 600
}
quick {
min_query_count: 128
min_duration: 6
max_duration: 60
}
rapid {
min_query_count: 64
min_duration: 6
max_duration: 60
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can define the settings for each run mode in the tasks.pbtxt file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the min_duration: 6 to min_duration: 10 for the quick mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for stable diffusion: max duration 40 seconds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes will be in #947

@mlcommons mlcommons deleted a comment from sonarqubecloud bot Dec 28, 2024
@anhappdev anhappdev marked this pull request as ready for review December 31, 2024 04:24
@anhappdev anhappdev requested a review from a team as a code owner December 31, 2024 04:24
@anhappdev anhappdev added the meta:awaiting-feedback Needs feedback or comment from others label Dec 31, 2024
@freedomtan
Copy link
Contributor

@AhmedTElthakeb please help test this.

@freedomtan
Copy link
Contributor

Let's try show which mode the app is running (so that we can tell it from the screenshot).

@anhappdev anhappdev merged commit 751e965 into master Jan 14, 2025
23 checks passed
@anhappdev anhappdev deleted the anh/lite-mode branch January 14, 2025 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
meta:awaiting-feedback Needs feedback or comment from others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new "general users friendly" mode
2 participants