Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI layouts #950

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

farook-edev
Copy link

This PR fixes #942 by making sure the app does not clip or overlap elements on extreme screen sizes.

The primary culprit behind the clipping was the many Expanded elements, those were simplified and only the variable size items (such as lists) were allowed to expand.

@farook-edev farook-edev requested review from anhappdev and a team as code owners January 18, 2025 22:10
Copy link

github-actions bot commented Jan 18, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@freedomtan
Copy link
Contributor

@freedomtan to check who is the MLCommons one who is responsible for this (adding a member to a repo, and find the CLA link).

@farook-edev

This comment was marked as resolved.

@anhappdev
Copy link
Collaborator

@farook-edev The screenshots I uploaded are just examples of the UI issue. I think there are more screens with similar issue. Could you please go through the UI of the app and fix all similar issue in this PR.

@farook-edev
Copy link
Author

farook-edev commented Jan 23, 2025

@anhappdev I tested the screens on a 1x3 aspect ratio device and a 3 inch screen, the only problem i noticed is sometimes the download bar in the resource screen overflows, I'll fix that.

I should also mention that this PR fixes a different issue that I noticed on the start screen, image attached:

Before
Screenshot_1737207941r

After
Screenshot_1737214443r

@farook-edev
Copy link
Author

added fixes for the following issues as well:
Screenshot_1737640758
Screenshot_1737640862
Screenshot_1737662832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UI / layout issues with uncommon screen sizes
3 participants