Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileextension not added for custom filenames #38

Open
L0ric0 opened this issue Jan 20, 2020 · 3 comments
Open

fileextension not added for custom filenames #38

L0ric0 opened this issue Jan 20, 2020 · 3 comments

Comments

@L0ric0
Copy link

L0ric0 commented Jan 20, 2020

when using a custom filename template the fileextenstion is not added.

@spencerhughes
Copy link

Even just having a %(filextension) template option would be awesome.

@mlj
Copy link
Owner

mlj commented Feb 28, 2021

Agree this is really dumb. As usual, there are a few options, in increasing order of complexity:

  1. We can peek at the filenames in the feed and use whatever extension is there.
  2. We can look at the media type in the HTTP response and try to determine the extension from there.
  3. We can try to look at the file itself and have a guess.

Option 1 is very simple but not very robust. Still, I think it is better than the current situation, so it may be worth starting with that.

@Spacewalker2
Copy link

Maybe it could be as simple as extension=opus or ext=opus. So the https://example.com/episodeX.opus gets downloaded instead of https://example.com/episodeX.mp3 which is the one in the feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants