Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type on array. #18

Open
treytomes opened this issue May 10, 2024 · 0 comments
Open

Missing type on array. #18

treytomes opened this issue May 10, 2024 · 0 comments

Comments

@treytomes
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/ml-regression-base/src/index.ts b/node_modules/ml-regression-base/src/index.ts
index e33697e..0dca7e9 100644
--- a/node_modules/ml-regression-base/src/index.ts
+++ b/node_modules/ml-regression-base/src/index.ts
@@ -18,13 +18,13 @@ export default class BaseRegression {
     }
   }
 
-  predict(x: number): number;
-  predict(x: NumberArray): number[];
+  // predict(x: number): number;
+  // predict(x: NumberArray): number[];
   predict(x: number | NumberArray) {
     if (typeof x === 'number') {
       return this._predict(x);
     } else if (isAnyArray(x)) {
-      const y = [];
+      const y: number[] = [];
       for (const xVal of x) {
         y.push(this._predict(xVal));
       }

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant