Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:period is confusing and limiting - here are some suggestions #22

Open
suan opened this issue Nov 12, 2015 · 1 comment
Open

:period is confusing and limiting - here are some suggestions #22

suan opened this issue Nov 12, 2015 · 1 comment

Comments

@suan
Copy link

suan commented Nov 12, 2015

First of all wanna thank you for this utility gem! Just wanna share some constructive suggestions.

I believe period: 0 should be the default. A very common case is to get a result (here we wanna enforce a period), and to have an "update" get for the result (where it's very important to have NO period as updates could happen at any time) As a result in my code I cannot use :period at all, cause the :period set when I "get" is gonna block me from making updates (which might happen soon after)

Hope that makes sense. In short I suggest:

  • make period: 0 the default
  • Add an option to ignore the period, perhaps ignore_period: true (this would allow one to "update" at anytime while still having a period for actual fetches)

EDIT: Actually I realized that I didn't have to wrap my update request at all - just needed to delete the local cache after the update, so the "option to ignore period" prob isn't as useful as I thought... still think period should default to 0 to reduce confusion tho

@axelson
Copy link

axelson commented Apr 21, 2016

I agree that period: 0 should be the default, or at least directly documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants