Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magic CLI]: The https://magic.modular.com/ install script isn't sufficient #3962

Open
jake-danton opened this issue Jan 22, 2025 · 0 comments
Labels
magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label

Comments

@jake-danton
Copy link

Issue description

The document doesn't call out the following dependencies, nor does the Magic installation script add them:

  • tzdata
  • build-essential
  • libedit2
  • zlib1g-dev
  • libtinfo-dev

It also doesn't set LLVM_SYMBOLIZER_PATH so the stack traces are not working fully.

Lastly, when running mojo test, all API doc tests result in the elf_dynamic_array_reader.h:64] tag not found error that shows up in many issues here (full stack trace in minimal repro repo linked in repro steps). I am guessing this is another missing dependency.

Steps to reproduce

I have a repo with a devcontainer setup that reproduces this: https://github.com/jake-danton/mojo_test/tree/main that also includes notes on the issues.

But to do so manually, start with a clean Ubuntu.

Then you have to get the following dependencies or various things break:

RUN apt-get update \
   && DEBIAN_FRONTEND=noninteractive TZ=$DEFAULT_TZ apt-get install -y \
   # Installation dependencies
   sudo \
   curl \
   # Magic/Pixi Dependencies
   # `magic init . --format mojoproject` fails otherwise
   tzdata \
   # C++ compiler and debugging dependencies
   build-essential \
   libedit2 \
   zlib1g-dev \
   libtinfo-dev \
   && rm -rf /var/lib/apt/lists/*

Run curl -ssL https://magic.modular.com/deb10c87-7449-475a-a82c-91b48d458b77 | bash

Run magic init . --format mojoproject

Add a function with an API documentation test

Run magic shell

Run mojo test

Version Info

- Provide magic CLI version by pasting the output of `magic --version`
magic 0.6.2 - (based on pixi 0.40.0)
- What OS did you install the magic CLI on?
Linux
- If you're on Linux include the flavor and version e.g. Ubuntu 22.04.
Ubuntu 24.04.1 LTS
- Include your CPU architecture e.g. x86-64 or arm64.
arm64
- If related to unresolvable dependencies, include the contents of your
`magic.lock` file.
@jake-danton jake-danton added magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label
Projects
None yet
Development

No branches or pull requests

1 participant