You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In MOM_state_initialization.F90:MOM_temp_salt_initialize_from_Z(), the default value for Z_INIT_ALE_REMAPPING is .false. and the default value of Z_INIT_REMAPPING_SCHEME is PPM_IH4:
For the MARBL driver, I am calling MOM_tracer_initialization_from_Z.F90:MOM_initialize_tracer_from_Z(), where the default values of those two parameters are .true. and PLM, respectively:
"The remapping scheme to use if using Z_INIT_ALE_REMAPPING is True.", &
default="PLM")
We are setting Z_INIT_ALE_REMAPPING=True in MOM_override, but I am still seeing the following warning from every call to MOM_initialize_tracer_from_Z():
WARNING: Previous msg:Z_INIT_ALE_REMAPPING = True ! [Boolean] default = False
WARNING: New message :Z_INIT_ALE_REMAPPING = True ! [Boolean] default = True
WARNING: Encountered inconsistent documentation line for parameter Z_INIT_ALE_REMAPPING!
WARNING: Previous msg:Z_INIT_REMAPPING_SCHEME = "PPM_IH4" ! default = "PPM_IH4"
WARNING: New message :Z_INIT_REMAPPING_SCHEME = "PLM" ! default = "PLM"
WARNING: Encountered inconsistent documentation line for parameter Z_INIT_REMAPPING_SCHEME!
I think the fix is to change the default values in MOM_tracer_initialization_from_Z.F90 to match those in MOM_state_initialization.F90:
call get_param(PF, mdl, "Z_INIT_ALE_REMAPPING", useALE, &
"If True, then remap straight to model coordinate from file.",&
- default=.true.)+ default=.false.)
call get_param(PF, mdl, "Z_INIT_REMAPPING_SCHEME", remapScheme, &
"The remapping scheme to use if using Z_INIT_ALE_REMAPPING is True.", &
- default="PLM")+ default="PPM_IH4")
Presuming my read of the situation is correct and this is a bug, the proposed change will be coming in via my MARBL driver branch eventually. If someone else wants to get it onto mom-ocean/main faster, or propose a different fix, that would be fine by me.
The text was updated successfully, but these errors were encountered:
In
MOM_state_initialization.F90:MOM_temp_salt_initialize_from_Z()
, the default value forZ_INIT_ALE_REMAPPING
is.false.
and the default value ofZ_INIT_REMAPPING_SCHEME
isPPM_IH4
:MOM6/src/initialization/MOM_state_initialization.F90
Lines 2561 to 2566 in b57ff02
For the MARBL driver, I am calling
MOM_tracer_initialization_from_Z.F90:MOM_initialize_tracer_from_Z()
, where the default values of those two parameters are.true.
andPLM
, respectively:MOM6/src/initialization/MOM_tracer_initialization_from_Z.F90
Lines 112 to 117 in b57ff02
We are setting
Z_INIT_ALE_REMAPPING=True
inMOM_override
, but I am still seeing the following warning from every call toMOM_initialize_tracer_from_Z()
:I think the fix is to change the default values in
MOM_tracer_initialization_from_Z.F90
to match those inMOM_state_initialization.F90
:Presuming my read of the situation is correct and this is a bug, the proposed change will be coming in via my MARBL driver branch eventually. If someone else wants to get it onto
mom-ocean/main
faster, or propose a different fix, that would be fine by me.The text was updated successfully, but these errors were encountered: