Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface salt flux forcing file #751

Open
ElizabethYankovsky opened this issue Apr 20, 2018 · 4 comments
Open

Surface salt flux forcing file #751

ElizabethYankovsky opened this issue Apr 20, 2018 · 4 comments
Assignees

Comments

@ElizabethYankovsky
Copy link
Contributor

In the ocean_only forcing file please add the ability to specify a surface salt flux from an input file. Thanks!

@MJHarrison-GFDL
Copy link
Contributor

Just a comment that this is a feature in the coupled driver

https://github.com/NOAA-GFDL/MOM6/blob/dev/gfdl/config_src/coupled_driver/MOM_surface_forcing.F90#L775

whereby the data_table is used to specify a salt_flux adjustment. There are no data_override calls in the solo_driver, but should be straightforward to add I think.

@sanAkel
Copy link
Collaborator

sanAkel commented May 13, 2022

Hi @ElizabethYankovsky, @MJHarrison-GFDL,

(In a totally unrelated conversation @Hallberg-NOAA mentioned this issue, so I am looking at it.)

Just for clarity,

  1. @ElizabethYankovsky are you asking for SALT_RESTORE_FILE, for e.g. in the ice-ocean coupled case, is set via https://github.com/NOAA-GFDL/MOM6-examples/blob/a24160720021d0e1a5f38aa41a10d69d289bb97d/ice_ocean_SIS2/OM4_025/MOM_saltrestore#L14
  2. @MJHarrison-GFDL since our code has been re-organized, the code block is: https://github.com/NOAA-GFDL/MOM6/blob/0e8acd90b46656ccb7fbc73bc5911ef2733a345c/config_src/drivers/FMS_cap/MOM_surface_forcing_gfdl.F90#L1584-L1592 ?

Thanks!

@sanAkel sanAkel self-assigned this May 13, 2022
@MJHarrison-GFDL
Copy link
Contributor

MJHarrison-GFDL commented May 13, 2022 via email

@sanAkel
Copy link
Collaborator

sanAkel commented May 13, 2022

Thanks @MJHarrison-GFDL, will do. I plan to use something similar to https://github.com/NOAA-GFDL/MOM6-examples/blob/dev/gfdl/ice_ocean_SIS2/OM4_025/preprocessing/interpSaltRestore_WOA05.py of course following @raphaeldussin's suggestion xesmf.

marshallward pushed a commit to marshallward/MOM6 that referenced this issue Nov 13, 2024
Most modules that use remapping have their own parameter e.g.
Z_INIT_REMAPPING_SCHEME.  However, OBC, ODA and SPONGE currently
sliently use the primary ALE REMAPPING_SCHEME parameter.

Added logged parameters OBC_REMAPPING_SCHEME, ODA_REMAPPING_SCHEME
and SPONGE_REMAPPING_SCHEME to allow customization.  All take
REMAPPING_SCHEME as their default to maintain compatibility.

For ODA, also added ODA_REMAPPING_USE_OM4_SUBCELLS that takes
REMAPPING_USE_OM4_SUBCELLS as its default to maintain compatibility,
and ODA_BOUNDARY_EXTRAP that takes BOUNDARY_EXTRAPOLATION as its
default to maintain compatibility.  Note that BOUNDARY_EXTRAPOLATION
is a bug, it should have been REMAP_BOUNDARY_EXTRAP, but the former
remains the default for compatibility.

For SPONGE, also added SPONGE_BOUNDARY_EXTRAP that takes
BOUNDARY_EXTRAPOLATION as its default to maintain compatibility.
Note that BOUNDARY_EXTRAPOLATION is a bug, it should have been
REMAP_BOUNDARY_EXTRAP, but the former remains the default for
compatibility.

Answers are unchanged, but there are new logged parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants