-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ElectrumWords::get_invalid_word #9466
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, I'd just leave an additional comment wherever else Language
s are defined directing devs working on languages here
or some other solution which uses a general list of the Language
s
... but ... I actually have to recheck if this is really needed. I forgot that only the first 3 letters really matter... This might still be helpful |
|
? |
I have rebased with the new changes |
Fixes monero-project/monero-gui#4342
Please review and feedback