Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhodesia Charter decision hands colonies to the UK even when other tags own them #99

Open
rogerburks opened this issue Jun 2, 2021 · 1 comment · May be fixed by #100
Open

Rhodesia Charter decision hands colonies to the UK even when other tags own them #99

rogerburks opened this issue Jun 2, 2021 · 1 comment · May be fixed by #100
Assignees

Comments

@rogerburks
Copy link
Collaborator

The decision rhodesia_charter awards Rhodesian and Malawi provinces to the UK even when other countries own them. The code that does this is here, which does not check if the provinces are already owned by another tag:

2015 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2013 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2014 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2012 = { secede_province = THIS any_pop = { literacy = -0.99 } }
790 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2017 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2016 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2018 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2067 = { secede_province = THIS any_pop = { literacy = -0.99 } }
2066 = { secede_province = THIS any_pop = { literacy = -0.99 } }

The following pair of screenshots were taken on the same game day. Before the decision:

image

After the decision:

image

Potentially, this decision should check if the provinces are empty or not, and if they are part of a colonial race, although truly I do not exactly see why this decision should secede_province at all. The UK will normally outrace all other tags at obtaining these provinces, but if it cannot, then the game should reflect that. For this reason, I suggest that the best solution is to simply remove all of the secede_province statements.

@rogerburks
Copy link
Collaborator Author

Here is the effect of this same scenario with proposed fixes:

image

@rogerburks rogerburks self-assigned this Jun 3, 2021
@rogerburks rogerburks linked a pull request Feb 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant