Heiqi Jun to the proper owner #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y event. This flag is used to award Tonkin to the proper owner if Qing is defeated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #147
In the follow ups to event 999951 "The Black Flag Army", Heiqi Jun is released and a war begins with the previous owner of colonial Tonkin. There is an issue with the resolution of this war, in that anyone with a Qing truce may take Tonkin in the decision treaty_of_tientsin_france.
In one of the more egregious examples of this bug, satellite Norway can be awarded Tonkin instead of overlord Sweden:
Fortunately, there is a relatively easy fix to this, to add a flag to the country that experiences event 99951, and then to verify the flag in the decision.
A flag is added to the country that owns Tonkin in the Black Flag Army event. This flag is used to award Tonkin to the proper owner if Qing is defeated: