Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inherit_ryukyu be regulated mainly by the allow and not the potential #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make inherit_ryukyu be regulated mainly by the allow and not the potential #153

wants to merge 1 commit into from

Conversation

rogerburks
Copy link
Collaborator

References #152

As a request from someone else who played as Japan, I intend to move much of the potential to the allow, while keeping the value of the potential as a gatekeeper for visibility. The point of this is to make the requirements for annexing Ryukyu more visible, so that the player can better plan to do this effectively. Player protection remains.

Specifically, I mean this text:

ccHFM/ccHFM/decisions/Japan.txt

Lines 1247 to 1261 in 47becfb

OR = {
tag = QNG
AND = {
tag = JAP
has_country_modifier = fukoku_kyohei
OR = {
has_country_flag = taiwan_line_of_advantage
revolution_n_counterrevolution = 1
}
}
AND = {
tag = TKG
has_country_modifier = fukoku_kyohei
}
}

The potential has a section added to ensure that only Qing, Japan, and Tokugawa Japan can see it.

@rogerburks
Make inherit_ryukyu be regulated mainly by the allow and not the pote…
173b269 
…ntial

For inherit_ryukyu, moves much of the potential to the allow for better visibility of gatekeeper conditions. This was done by request from another player who played as Japan. The benefit of this is to allow the player to better understand the requirements for annexation of Ryukyu.
@rogerburks rogerburks requested a review from moretrim February 20, 2022 19:50
@rogerburks rogerburks self-assigned this Feb 20, 2022
@rogerburks rogerburks added the enhancement New feature or request label Feb 20, 2022
@rogerburks rogerburks linked an issue Feb 20, 2022 that may be closed by this pull request
Make inherit_ryukyu be regulated mainly by the allow and not the potential #152
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moretrim moretrim Awaiting requested review from moretrim

At least 1 approving review is required to merge this pull request.

Assignees

@rogerburks rogerburks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make inherit_ryukyu be regulated mainly by the allow and not the potential
1 participant
@rogerburks