Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] String extraction duplicates shared strings within addons #10088

Open
flodolo opened this issue Dec 3, 2024 · 1 comment
Open

[l10n] String extraction duplicates shared strings within addons #10088

flodolo opened this issue Dec 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@flodolo
Copy link
Collaborator

flodolo commented Dec 3, 2024

@mcleinman

Unfortunately the string extraction is not working as it should: shared strings (like vpn.commonStrings.generalUpdateBulletIntro), are extracted twice, once in en/addons/strings.xliff, once in the addon (e.g. en/addons/message_update_v2.25/strings.xliff).

Should we ignore strings starting with vpn.commonStrings when generating addons? While it could be done in the l10n repository as an additional workflow step, I think the clean approach is to fix it in this repo, where addon strings are extracted.

In order to unblock translation, should I go ahead and manually remove shared strings from whats_new_v2.25?

@mcleinman
Copy link
Collaborator

Yes, we can manually remove shared strings from whats_new_v2.25 and message_update_v2.25, or just close that current PR.

I have a fix for this up, and the description includes more diagnosis / explanation. Sorry about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants