Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Make addons-frontend Compatible with Multiple Promoted Addon Groups #15226

Closed
2 tasks
chrstinalin opened this issue Dec 4, 2024 · 4 comments · Fixed by mozilla/addons-frontend#13343
Closed
2 tasks
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@chrstinalin
Copy link

chrstinalin commented Dec 4, 2024

Description

mozilla/addons-server#22888 breaks the addons-frontend as it cannot handle more than one promoted add-on group.

It should be able to handle the changes in the patch, while continuing to handle single promotions while #22888 is not merged.

Even once #22888 is merged, only one badge can be shown at a time. If an add-on is both LINE and RECOMMENDED, it should only display the RECOMMENDED badge.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

@willdurand @chrstinalin

I've some questions about this:

  • a partner add-on is : recommended + by firefox badge?
  • how can I set it up to get both badges on frontend ? I tried from promoted module on dev but I don't see a way...

@chrstinalin
Copy link
Author

chrstinalin commented Dec 11, 2024

@willdurand @chrstinalin

I've some questions about this:

  • a partner add-on is : recommended + by firefox badge?
  • how can I set it up to get both badges on frontend ? I tried from promoted module on dev but I don't see a way...

@ioanarusiczki We're choosing only to show one badge, even if an add-on has multiple, based on the "importance" of the add-on. (Recommended, then line). Apologies, I forgot to update the issue.

For now (until the backend portion of this is merged), the only thing that needs to be verified is that everything still shows as expected (i.e nothing has changed), as there's no way for an add-on to have multiple groups until then.

@ioanarusiczki
Copy link

ioanarusiczki commented Dec 11, 2024

@chrstinalin np, thanks for clarifying.

I didn't finish yet but so far I didn't find anything unusual on frontend recommended/by firefox badges.
Definitely cannot add 2 promotions for one extension, I could only add one of the two.
I could add the recommended badge for themes using Mozilla Collection.

@ioanarusiczki
Copy link

I'm done with regression testing and I did not see issues:

  • I could set up new badges - recommended or by firefox
  • looked over search results, autocomplete, detail pages, user profile pages -> look as before for recommended, by firefox.

I won't mark this issue verified yet because I've info about the future ux for partner add-ons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants