Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Nike ad doesn't start playing. #471

Open
mbebenita opened this issue Aug 6, 2013 · 2 comments
Open

Nike ad doesn't start playing. #471

mbebenita opened this issue Aug 6, 2013 · 2 comments
Labels
as2/avm1
Milestone
M4: Shumway rides...

Comments

@mbebenita
Copy link
Contributor

SWF: db4179e0900db3e45642ea72c531905df16d7ae086ca124c352f8e7eff5fe3cd (Direct Link)
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 30, 2013
@tschneidereit
Properly fall back to default style for style-less shape paths
7e7e020 
Fixes parts of mozilla#471
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 30, 2013
@tschneidereit
Only set the name property for display objects that have AS2 reflections
54ccce0 
Fixes parts of mozilla#471
tschneidereit added a commit that referenced this issue Oct 30, 2013
@tschneidereit
Merge pull request #910 from tschneidereit/master
f110ce9 
Fixes for #471
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 30, 2013
@tschneidereit
Bugfixes in AS2Utils
38361db 
Lets the ad from mozilla#471 get slightly further
@tschneidereit tschneidereit mentioned this issue Oct 30, 2013
Merged
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 31, 2013
@tschneidereit
Implement AS2 TextField.variable accessor
fcec5e9 
Lets the ad from mozilla#471 get ever so slightly further
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 31, 2013
@tschneidereit
Implement AS2's TextFormat#getTextExtent
a4d24ed 
Another fix for the ad from mozilla#471
@tschneidereit tschneidereit mentioned this issue Oct 31, 2013
Merged
tschneidereit added a commit to tschneidereit/shumway that referenced this issue Oct 31, 2013
@tschneidereit
Implement AS2's TextFormat#getTextExtent
23c12e4 
Another fix for the ad from mozilla#471
@tschneidereit
Copy link
Contributor

So, after fixing 5 different issues, the ad plays for a few seconds. It stops with the error Error: long running script -- AVM1 instruction limit is reached after that.

I don't actually think the instruction limit would be an issue, if everything else worked: there are three exceptions before this one:
AVM1 error: Error: Method SetProduct is not defined.
and
AVM1 error: TypeError: obj is undefined repeated twice

SetProduct is indeed not defined in the SWF. I don't know if we handle this properly - the Flash Player seems to happily ignore it. @yurydelendik, maybe you can take a look?

@cpeterso cpeterso modified the milestones: Release Landing, Nightly Landing Mar 7, 2014
@yurydelendik
Copy link
Contributor

SimpleAutosize function is relying on _xscale/_yscale/_width/_height to work properly in the TextField. It's stopping execution for right reason -- infinite loop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
as2/avm1
Projects
None yet
Milestone
M4: Shumway rides the trains
Development

No branches or pull requests
4 participants
@tschneidereit @mbebenita @cpeterso @yurydelendik