Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External errors which aren't used as an error in the original crate don't work correctly. #2393

Open
mhammond opened this issue Jan 9, 2025 · 0 comments

Comments

@mhammond
Copy link
Member

mhammond commented Jan 9, 2025

eg, consider crate-1 which defines an error enum, but where crate-1 doesn't actually use the error locally. When crate-2 tries to use that error enum it fails because crate-1 didn't generate everything needed for errors, because due to internal implementation details, it simply doesn't know it is an error.

This can be demonstrated by the patch in #2390 - it added a new exported function _just_to_get_error_support() purely to work around this. While this is also a semi-reasonable work-around, it's far from ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant