Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr refs shouldn't be under heads/ #551

Open
jgraham opened this issue Oct 25, 2019 · 0 comments
Open

pr refs shouldn't be under heads/ #551

jgraham opened this issue Oct 25, 2019 · 0 comments

Comments

@jgraham
Copy link
Member

jgraham commented Oct 25, 2019

When we pull prs from GitHub we end up with refs unders refs/heads/pr/. This is usually fine, except if someone creates a branch with the name pr/<number> upstream, in which case we get collisions. We should instead fetch PRs to refs/pulls/<number> so there can't be a collision. This may require some changes because the resulting refs won't show up in a list of branches (which are usually taken to be things under refs/heads/ only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant