Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI_REAL2 not always included in appropriate lists #831

Open
jeffhammond opened this issue Feb 2, 2024 · 3 comments
Open

MPI_REAL2 not always included in appropriate lists #831

jeffhammond opened this issue Feb 2, 2024 · 3 comments
Labels
mpi-6 For inclusion in the MPI 5.1 or 6.0 standard wg-abi ABI Working Group

Comments

@jeffhammond
Copy link
Member

jeffhammond commented Feb 2, 2024

Problem

Chapter 19:

We assume that for each typeclass (integer, real, complex) and each word size n there is a unique machine representation. For every pair (typeclass, n) supported by a compiler, MPI must provide a named size-specific datatype. The name of this datatype is of the form MPI_ in C and Fortran where is one of REAL, INTEGER, or COMPLEX, and is the length in bytes of the machine representation. This datatype locally matches all variables of type (typeclass, n) in Fortran. The list of names for such types includes:
MPI_REAL4
MPI_REAL8
MPI_REAL16
MPI_COMPLEX8
MPI_COMPLEX16
MPI_COMPLEX32
MPI_INTEGER1
MPI_INTEGER2
MPI_INTEGER4
MPI_INTEGER8
MPI_INTEGER16

MPI_REAL2 and MPI_COMPLEX4 should be listed here, or we should remove the list altogether and just give an example, since a full list exists elsewhere.

Proposal

Add it to the list or remove the list.

Changes to the Text

Trivial

Impact on Implementations

None

Impact on Users

Clarity

References and Pull Requests

@jeffhammond jeffhammond added wg-abi ABI Working Group mpi-5.0 For inclusion in the MPI 5.0 standard labels Feb 2, 2024
@github-project-automation github-project-automation bot moved this to To Do in MPI Next Feb 2, 2024
@wrwilliams
Copy link

+1 for remove list and add reference to the full list.

@jprotze
Copy link

jprotze commented Feb 5, 2024

Doesn't the includes: before the list already clarify that this is no complete list? I think, having 2 or three examples might be sufficient, or make the composition of the name more clear: MPI_XXXYYY, where XXX is in {INTEGER,REAL,COMPLEX} and YYY is the length in bytes without any 0 prefix.

@jeffhammond
Copy link
Member Author

Sure, "includes" isn't technically wrong for listing 11 of 13 cases, but since it doesn't say "includes, for example", it is reasonable for a reader to conclude it is a complete list.

It is better to ambiguous, and that's what I'll accomplish in the change. Details TBD.

@wesbland wesbland added mpi-6 For inclusion in the MPI 5.1 or 6.0 standard and removed mpi-5.0 For inclusion in the MPI 5.0 standard labels Jan 9, 2025
@wesbland wesbland removed this from MPI Next Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpi-6 For inclusion in the MPI 5.1 or 6.0 standard wg-abi ABI Working Group
Projects
Status: To Do
Development

No branches or pull requests

4 participants