Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get shots for specific season instead of all shots. #60

Closed
mpope9 opened this issue Nov 17, 2021 · 1 comment
Closed

Get shots for specific season instead of all shots. #60

mpope9 opened this issue Nov 17, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mpope9
Copy link
Owner

mpope9 commented Nov 17, 2021

OK, so the way shot_chart_detail is loaded can be simplified, potentially. Right now we fetch all shots for each player + team combo into a temp table. We then insert from the temp table into the main shot_chart_detail if the games exist. Instead, it'd be useful to try and fetch from the shotchartdetail API just for the games in the season. By also passing the GameID parameter.

The downside is that this could generate more requests and result in worse performance.

@mpope9 mpope9 added enhancement New feature or request good first issue Good for newcomers labels Nov 17, 2021
@mpope9
Copy link
Owner Author

mpope9 commented Nov 22, 2021

Not possible. #63 as an alternative.

@mpope9 mpope9 closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant