Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial value for epsilon is really high in estimate_joint #122

Open
sangeetabhatia03 opened this issue Jun 15, 2021 · 2 comments
Open

Initial value for epsilon is really high in estimate_joint #122

sangeetabhatia03 opened this issue Jun 15, 2021 · 2 comments

Comments

@sangeetabhatia03
Copy link
Collaborator

From Pierre:
R_init <- draw_R(mcmc_control$n_iter ... in estimate_joint function should really be R_init <- draw_R(epsilon = epsilon_init, ... otherwise initial value for epsilon is really high especially when increasing posterior sample...
@sangeetabhatia03
Copy link
Collaborator Author

sangeetabhatia03 commented Jun 15, 2021 •
edited
Loading

This is now fixed in https://github.com/mrc-ide/EpiEstim/tree/fix_122
commit d84c1e2
All tests pass ok.

@athowes
Copy link

athowes commented Sep 24, 2024

@sangeetabhatia03 has this been merged into main? If so, can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sangeetabhatia03 @athowes