Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nf-test workflow #173

Open
buehlere opened this issue Dec 18, 2024 · 2 comments
Open

Update nf-test workflow #173

buehlere opened this issue Dec 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@buehlere
Copy link
Collaborator

Our testing workflow has fallen behind nf-core's: https://nf-co.re/blog/2024/maintainers-minutes-2024-11-29.

It's starting to cause issues with CI/CD. For example with how nf-test is downloaded: https://github.com/mskcc-omics-workflows/modules/actions/runs/12381160481/job/34559103879?pr=172

nf-test is now split into multiple workflow:

We'll need to match these new testing workflows.

@buehlere
Copy link
Collaborator Author

buehlere commented Jan 6, 2025

I tried switching to the new CI/CD and it didn't fix the singularity issue: https://github.com/mskcc-omics-workflows/modules/pull/174/files#diff-5cd9e7e35a43dae25124955137a4cfd3defccc72c0c701844cd857cff0f4aeeb

@buehlere
Copy link
Collaborator Author

buehlere commented Jan 7, 2025

The issue was not enabling apptainer:

apptainer {
apptainer.enabled = true
apptainer.autoMounts = true
}

This PR should fix things: #174 . It also updates the CI.

@buehlere buehlere added the bug Something isn't working label Jan 9, 2025
@buehlere buehlere self-assigned this Jan 9, 2025
@buehlere buehlere marked this as a duplicate of #171 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant